spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Riaas Mokiem (JIRA)" <>
Subject [jira] [Created] (SPARK-23769) Remove unnecessary scalastyle check disabling
Date Thu, 22 Mar 2018 11:49:00 GMT
Riaas Mokiem created SPARK-23769:

             Summary: Remove unnecessary scalastyle check disabling
                 Key: SPARK-23769
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.4.0
            Reporter: Riaas Mokiem

In `org/apache/spark/util/CompletionIterator.scala` the Scalastyle checker is disabled for
1 line of code. However, this line of code doesn't seem to violate any of the currently active
rules for Scalastyle. So the Scalastyle checker doesn't need to be disabled there. 

I've tested this by removing the comments that disable the checker and running the checker
with `build/mv scalastyle:check`. With the comments removed (so with the checker active for
that line) the build still succeeds and no violations are shown in `core/target/scalastyle-output.xml`.
I'll create a pull request to remove the comments that disable the checker.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message