spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-23760) CodegenContext.withSubExprEliminationExprs should save/restore CSE state correctly
Date Wed, 21 Mar 2018 05:08:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-23760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407466#comment-16407466
] 

Apache Spark commented on SPARK-23760:
--------------------------------------

User 'rednaxelafx' has created a pull request for this issue:
https://github.com/apache/spark/pull/20870

> CodegenContext.withSubExprEliminationExprs should save/restore CSE state correctly
> ----------------------------------------------------------------------------------
>
>                 Key: SPARK-23760
>                 URL: https://issues.apache.org/jira/browse/SPARK-23760
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.2.0, 2.2.1, 2.3.0
>            Reporter: Kris Mok
>            Priority: Major
>
> There's a bug in {{CodegenContext.withSubExprEliminationExprs()}} that makes it effectively
always clear the subexpression elimination state after it's called.
> The original intent of this function was that it should save the old state, set the given
new state as current and perform codegen (invoke {{Expression.genCode()}}), and at the end
restore the subexpression elimination state back to the old state. This ticket tracks a fix
to actually implement the original intent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message