spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saisai Shao (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (SPARK-23743) IsolatedClientLoader.isSharedClass returns an unindented result against `slf4j` keyword
Date Fri, 30 Mar 2018 06:12:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-23743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Saisai Shao reassigned SPARK-23743:
-----------------------------------

    Assignee: Jongyoul Lee

> IsolatedClientLoader.isSharedClass returns an unindented result against `slf4j` keyword
> ---------------------------------------------------------------------------------------
>
>                 Key: SPARK-23743
>                 URL: https://issues.apache.org/jira/browse/SPARK-23743
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Jongyoul Lee
>            Assignee: Jongyoul Lee
>            Priority: Minor
>             Fix For: 2.4.0
>
>
> {{isSharedClass}} returns if some classes can/should be shared or not. It checks if the
classes names have some keywords or start with some names. Following the logic, it can occur
unintended behaviors when a custom package has {{slf4j}} inside the package or class name.
As I guess, the first intention seems to figure out the class containing {{org.slf4j}}. It
would be better to change the comparison logic to {{name.startsWith("org.slf4j")}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message