spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyukjin Kwon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-23691) Use sql_conf util in PySpark tests where possible
Date Tue, 20 Mar 2018 04:41:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-23691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405799#comment-16405799
] 

Hyukjin Kwon commented on SPARK-23691:
--------------------------------------

(y)

> Use sql_conf util in PySpark tests where possible
> -------------------------------------------------
>
>                 Key: SPARK-23691
>                 URL: https://issues.apache.org/jira/browse/SPARK-23691
>             Project: Spark
>          Issue Type: Improvement
>          Components: PySpark
>    Affects Versions: 2.3.0
>            Reporter: Hyukjin Kwon
>            Assignee: Hyukjin Kwon
>            Priority: Minor
>             Fix For: 2.4.0
>
>
> https://github.com/apache/spark/commit/d6632d185e147fcbe6724545488ad80dce20277e added
an useful util
> {code}
> @contextmanager
> def sql_conf(self, pairs):
>     ...
> {code}
> to allow configuration set/unset within a block:
> {code}
> with self.sql_conf({"spark.blah.blah.blah", "blah"})
>     # test codes
> {code}
> It would be nicer if we use it. 
> Note that there look already few places affecting tests without restoring the original
value back in unittest classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message