Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7237200D5C for ; Fri, 1 Dec 2017 03:56:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B5917160C01; Fri, 1 Dec 2017 02:56:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC411160C04 for ; Fri, 1 Dec 2017 03:56:05 +0100 (CET) Received: (qmail 22670 invoked by uid 500); 1 Dec 2017 02:56:05 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 22661 invoked by uid 99); 1 Dec 2017 02:56:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Dec 2017 02:56:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4624DC5DA7 for ; Fri, 1 Dec 2017 02:56:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id J7M5lotu_iqA for ; Fri, 1 Dec 2017 02:56:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2820D5FAC2 for ; Fri, 1 Dec 2017 02:56:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0762BE25A6 for ; Fri, 1 Dec 2017 02:56:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E8A0221075 for ; Fri, 1 Dec 2017 02:56:00 +0000 (UTC) Date: Fri, 1 Dec 2017 02:56:00 +0000 (UTC) From: "Wenchen Fan (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (SPARK-22653) executorAddress registered in CoarseGrainedSchedulerBackend.executorDataMap is null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Dec 2017 02:56:06 -0000 [ https://issues.apache.org/jira/browse/SPARK-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenchen Fan reassigned SPARK-22653: ----------------------------------- Assignee: Thomas Graves > executorAddress registered in CoarseGrainedSchedulerBackend.executorDataMap is null > ----------------------------------------------------------------------------------- > > Key: SPARK-22653 > URL: https://issues.apache.org/jira/browse/SPARK-22653 > Project: Spark > Issue Type: Bug > Components: Scheduler > Affects Versions: 2.2.0 > Reporter: Thomas Graves > Assignee: Thomas Graves > Fix For: 2.3.0 > > > In CoarseGrainedSchedulerBackend.RegisterExecutor the executor data address (executorRef.address) can be null. > val data = new ExecutorData(executorRef, executorRef.address, hostname, > cores, cores, logUrls) > At this point the executorRef.address can be null, there is actually code above it that handles this case: > // If the executor's rpc env is not listening for incoming connections, `hostPort` > // will be null, and the client connection should be used to contact the executor. > val executorAddress = if (executorRef.address != null) { > executorRef.address > } else { > context.senderAddress > } > But it doesn't use executorAddress when it creates the ExecutorData. > This causes removeExecutor to never remove it properly from addressToExecutorId. > addressToExecutorId -= executorInfo.executorAddress > This is also a memory leak and can also call onDisconnected to call disableExecutor when it shouldn't. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org