spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyukjin Kwon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-7721) Generate test coverage report from Python
Date Thu, 28 Dec 2017 07:01:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305108#comment-16305108
] 

Hyukjin Kwon commented on SPARK-7721:
-------------------------------------

I roughly checked the coverage results and seems fine. There is one trivial nit tho - https://github.com/apache/spark/blob/04e44b37cc04f62fbf9e08c7076349e0a4d12ea8/python/pyspark/daemon.py#L148-L169
this scope is not in the coverage results as basically I am producing the coverage results
in {{worker.py}} separately and then merging it. I believe it's not a big deal.

So, if you are fine for all now, how about if i proceed this by two PRs

1. Adding the script only (of course after cleaning up)

   Adding script alone should also be useful when reviewers check PRs, they can at least manually
run it.

2. Integrating with Jenkins

  I have two thoughts for this:

  - Simplest one: Only run it in a specific mater in Jenkins and we always only keep a single
up-to-date coverage site. It's simple. We can just simply push it. I think this is quite straightforward
and pretty feasible. 

  - Another one: I make a simple site to list up all other coverages of all other builds (including
PR builds) in git pages, and then leave a link in each PR's Jenkins build success message.
I think this's also feasible but I think I need to take a look further.

BTW, I will be able to start to work on this from next week or two weeks after ..

> Generate test coverage report from Python
> -----------------------------------------
>
>                 Key: SPARK-7721
>                 URL: https://issues.apache.org/jira/browse/SPARK-7721
>             Project: Spark
>          Issue Type: Test
>          Components: PySpark, Tests
>            Reporter: Reynold Xin
>
> Would be great to have test coverage report for Python. Compared with Scala, it is tricker
to understand the coverage without coverage reports in Python because we employ both docstring
tests and unit tests in test files. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message