spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Cutler (JIRA)" <>
Subject [jira] [Commented] (SPARK-22147) BlockId.hashCode allocates a StringBuilder/String on each call
Date Fri, 03 Nov 2017 15:33:00 GMT


Bryan Cutler commented on SPARK-22147:

Sorry, I linked the above PR to this JIRA accidentally

> BlockId.hashCode allocates a StringBuilder/String on each call
> --------------------------------------------------------------
>                 Key: SPARK-22147
>                 URL:
>             Project: Spark
>          Issue Type: Improvement
>          Components: Block Manager
>    Affects Versions: 2.2.0
>            Reporter: Sergei Lebedev
>            Assignee: Sergei Lebedev
>            Priority: Minor
>             Fix For: 2.3.0
> The base class {{BlockId}} [defines|]
{{hashCode}} and {{equals}} for all its subclasses in terms of {{name}}. This makes the definitions
of different ID types [very concise|].
The downside, however, is redundant allocations. While I don't think this could be the major
issue, it is still a bit disappointing to increase GC pressure on the driver for nothing.
For our machine learning workloads, we've seen as much as 10% of all allocations on the driver
coming from {{BlockId.hashCode}} calls done for [BlockManagerMasterEndpoint.blockLocations|].

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message