spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-20943) Correct BypassMergeSortShuffleWriter's comment
Date Thu, 01 Jun 2017 09:56:04 GMT

     [ https://issues.apache.org/jira/browse/SPARK-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Owen updated SPARK-20943:
------------------------------
       Priority: Trivial  (was: Major)
    Component/s:     (was: Spark Core)
                 Documentation

It's not clear what comment you're proposing and why. Please set JIRA fields reasonably.

> Correct BypassMergeSortShuffleWriter's comment
> ----------------------------------------------
>
>                 Key: SPARK-20943
>                 URL: https://issues.apache.org/jira/browse/SPARK-20943
>             Project: Spark
>          Issue Type: Improvement
>          Components: Documentation, Shuffle
>    Affects Versions: 2.1.1
>            Reporter: CanBin Zheng
>            Priority: Trivial
>              Labels: starter
>
> There are some comments written in BypassMergeSortShuffleWriter.java about when to select
this write path´╝î the three required conditions are described as follows:  
> 1. no Ordering is specified, and
> 2. no Aggregator is specified, and
> 3. the number of partitions is less than 
>  spark.shuffle.sort.bypassMergeThreshold
> Obviously, the conditions written are partially wrong and misleading, the right conditions
should be:
> 1. map-side combine is false, and
> 2. the number of partitions is less than 
>  spark.shuffle.sort.bypassMergeThreshold



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message