spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcelo Vanzin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-20205) DAGScheduler posts SparkListenerStageSubmitted before updating stage
Date Mon, 03 Apr 2017 23:54:41 GMT

    [ https://issues.apache.org/jira/browse/SPARK-20205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954357#comment-15954357
] 

Marcelo Vanzin commented on SPARK-20205:
----------------------------------------

bq. I was referring to the case where we are persisting to event log or consuming events to
externally persist them.

I see. In that case I believe it will always be unset. For live listeners, current time is
a good enough approximation, but for the history server, for example, that's not an option
(since {{SparkListenerStageSubmitted}} does not have a {{time}} field).

> DAGScheduler posts SparkListenerStageSubmitted before updating stage
> --------------------------------------------------------------------
>
>                 Key: SPARK-20205
>                 URL: https://issues.apache.org/jira/browse/SPARK-20205
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.2.0
>            Reporter: Marcelo Vanzin
>
> Probably affects other versions, haven't checked.
> The code that submits the event to the bus is around line 991:
> {code}
>     stage.makeNewStageAttempt(partitionsToCompute.size, taskIdToLocations.values.toSeq)
>     listenerBus.post(SparkListenerStageSubmitted(stage.latestInfo, properties))
> {code}
> Later in the same method, the stage information is updated (around line 1057):
> {code}
>     if (tasks.size > 0) {
>       logInfo(s"Submitting ${tasks.size} missing tasks from $stage (${stage.rdd}) (first
15 " +
>         s"tasks are for partitions ${tasks.take(15).map(_.partitionId)})")
>       taskScheduler.submitTasks(new TaskSet(
>         tasks.toArray, stage.id, stage.latestInfo.attemptId, jobId, properties))
>       stage.latestInfo.submissionTime = Some(clock.getTimeMillis())
> {code}
> That means an event handler might get a stage submitted event with an unset submission
time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message