Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5CD20200C2B for ; Thu, 2 Mar 2017 10:37:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5B630160B7A; Thu, 2 Mar 2017 09:37:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A444F160B6F for ; Thu, 2 Mar 2017 10:37:48 +0100 (CET) Received: (qmail 61287 invoked by uid 500); 2 Mar 2017 09:37:47 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 61277 invoked by uid 99); 2 Mar 2017 09:37:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 09:37:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7B037C1D3C for ; Thu, 2 Mar 2017 09:37:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.546 X-Spam-Level: X-Spam-Status: No, score=-1.546 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2CtOHMwrODsx for ; Thu, 2 Mar 2017 09:37:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C7BE5FB59 for ; Thu, 2 Mar 2017 09:37:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9107DE05F0 for ; Thu, 2 Mar 2017 09:37:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 48E2E2415A for ; Thu, 2 Mar 2017 09:37:45 +0000 (UTC) Date: Thu, 2 Mar 2017 09:37:45 +0000 (UTC) From: "Apache Spark (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-19793) Use clock.getTimeMillis when mark task as finished in TaskSetManager. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Mar 2017 09:37:49 -0000 [ https://issues.apache.org/jira/browse/SPARK-19793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891924#comment-15891924 ] Apache Spark commented on SPARK-19793: -------------------------------------- User 'jinxing64' has created a pull request for this issue: https://github.com/apache/spark/pull/17133 > Use clock.getTimeMillis when mark task as finished in TaskSetManager. > --------------------------------------------------------------------- > > Key: SPARK-19793 > URL: https://issues.apache.org/jira/browse/SPARK-19793 > Project: Spark > Issue Type: Bug > Components: Scheduler > Affects Versions: 2.1.0 > Reporter: jin xing > Priority: Minor > > TaskSetManager is now using *System.getCurrentTimeMillis* when mark task as finished in *handleSuccessfulTask* and *handleFailedTask*. Thus developer cannot set the tasks finishing time in unit test. When *handleSuccessfulTask*, task's duration = System.getCurrentTimeMillis - launchTime(which can be set by *clock*), the result is not correct. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org