spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Seth Hendrickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-20083) Change matrix toArray to not create a new array when matrix is already column major
Date Mon, 27 Mar 2017 19:14:41 GMT

    [ https://issues.apache.org/jira/browse/SPARK-20083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943873#comment-15943873
] 

Seth Hendrickson commented on SPARK-20083:
------------------------------------------

Yes, that would be the intention. We have to take care to change the existing code when we
require a new array from {{toArray}} when we implement this change.

> Change matrix toArray to not create a new array when matrix is already column major
> -----------------------------------------------------------------------------------
>
>                 Key: SPARK-20083
>                 URL: https://issues.apache.org/jira/browse/SPARK-20083
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.2.0
>            Reporter: Seth Hendrickson
>            Priority: Minor
>
> {{toArray}} always creates a new array in column major format, even when the resulting
array is the same as the backing values. We should change this to just return a reference
to the values array when it is already column major.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message