spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph K. Bradley (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-19899) FPGrowth input column naming
Date Mon, 20 Mar 2017 17:59:41 GMT

     [ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joseph K. Bradley resolved SPARK-19899.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.2.0

Issue resolved by pull request 17321
[https://github.com/apache/spark/pull/17321]

> FPGrowth input column naming
> ----------------------------
>
>                 Key: SPARK-19899
>                 URL: https://issues.apache.org/jira/browse/SPARK-19899
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.2.0
>            Reporter: Maciej Szymkiewicz
>            Assignee: Maciej Szymkiewicz
>             Fix For: 2.2.0
>
>
> Current implementation extends {{HasFeaturesCol}}. Personally I find it rather unfortunate.
Up to this moment we used consistent conventions - if we mix-in  {{HasFeaturesCol}} the {{featuresCol}}
should be {{VectorUDT}}. 
> Using the same {{Param}} for an {{array<T>}} (and possibly for {{array<arrray<T>>}}
once {{PrefixSpan}} is ported to {{ml}}) will be confusing for the users.
> I would like to suggest adding new {{trait}} (let's say {{HasTransactionsCol}}) to clearly
indicate that the input type differs for the other {{Estiamtors}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message