spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jin xing (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-19450) Replace askWithRetry with askSync.
Date Fri, 03 Feb 2017 17:21:51 GMT

     [ https://issues.apache.org/jira/browse/SPARK-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

jin xing updated SPARK-19450:
-----------------------------
    Description: 
*askSync* is already added in *RpcEndpointRef* (see SPARK-19347 and https://github.com/apache/spark/pull/16690#issuecomment-276850068)
and *askWithRetry* is marked as deprecated. 
As mentioned SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):

??askWithRetry is basically an unneeded API, and a leftover from the akka days that doesn't
make sense anymore. It's prone to cause deadlocks (exactly because it's blocking), it imposes
restrictions on the caller (e.g. idempotency) and other things that people generally don't
pay that much attention to when using it.??

Since *askWithRetry* is just used inside spark and not in user logic. It might make sense
to replace all of them with *askSync*.

  was:
*askSync* is already added in *RpcEndpointRef* (see SPARK-19347 and https://github.com/apache/spark/pull/16690#issuecomment-276850068)
and *askWithRetry* is marked as deprecated. 
As mentioned SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):

??askWithRetry is that it's basically an unneeded API, and a leftover from the akka days that
doesn't make sense anymore. It's prone to cause deadlocks (exactly because it's blocking),
it imposes restrictions on the caller (e.g. idempotency) and other things that people generally
don't pay that much attention to when using it.??

Since *askWithRetry* is just used inside spark and not in user logic. It might make sense
to replace all of them with *askSync*.


> Replace askWithRetry with askSync.
> ----------------------------------
>
>                 Key: SPARK-19450
>                 URL: https://issues.apache.org/jira/browse/SPARK-19450
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.1.0
>            Reporter: jin xing
>
> *askSync* is already added in *RpcEndpointRef* (see SPARK-19347 and https://github.com/apache/spark/pull/16690#issuecomment-276850068)
and *askWithRetry* is marked as deprecated. 
> As mentioned SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):
> ??askWithRetry is basically an unneeded API, and a leftover from the akka days that doesn't
make sense anymore. It's prone to cause deadlocks (exactly because it's blocking), it imposes
restrictions on the caller (e.g. idempotency) and other things that people generally don't
pay that much attention to when using it.??
> Since *askWithRetry* is just used inside spark and not in user logic. It might make sense
to replace all of them with *askSync*.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message