spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "yuhao yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-18613) spark.ml LDA classes should not expose spark.mllib in APIs
Date Mon, 28 Nov 2016 22:49:58 GMT

    [ https://issues.apache.org/jira/browse/SPARK-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703396#comment-15703396
] 

yuhao yang commented on SPARK-18613:
------------------------------------

Sounds good to me. Will you send a PR?

> spark.ml LDA classes should not expose spark.mllib in APIs
> ----------------------------------------------------------
>
>                 Key: SPARK-18613
>                 URL: https://issues.apache.org/jira/browse/SPARK-18613
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Priority: Critical
>
> spark.ml.LDAModel exposes dependencies on spark.mllib in 2 methods, but it should not:
> * {{def oldLocalModel: OldLocalLDAModel}}
> * {{def getModel: OldLDAModel}}
> This task is to deprecate those methods.  I recommend creating {{private[ml]}} versions
of the methods which are used internally in order to avoid deprecation warnings.
> Setting target for 2.2, but I'm OK with getting it into 2.1 if we have time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message