spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Pentreath (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-18341) Eliminate use of SingularMatrixException in WeightedLeastSquares logic
Date Fri, 11 Nov 2016 13:50:58 GMT

    [ https://issues.apache.org/jira/browse/SPARK-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657117#comment-15657117
] 

Nick Pentreath commented on SPARK-18341:
----------------------------------------

Just for interest - why is an error code more desirable?

> Eliminate use of SingularMatrixException in WeightedLeastSquares logic
> ----------------------------------------------------------------------
>
>                 Key: SPARK-18341
>                 URL: https://issues.apache.org/jira/browse/SPARK-18341
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Priority: Minor
>
> WeightedLeastSquares uses an Exception to implement fallback logic for which solver to
use: [https://github.com/apache/spark/blob/6f3697136aa68dc39d3ce42f43a7af554d2a3bf9/mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala#L258]
> We should use an error code instead of an exception.
> * Note the error code should be internal, not a public API.
> * We may be able to eliminate the SingularMatrixException class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message