spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-18292) LogicalPlanToSQLSuite should not use resource dependent path for golden file generation
Date Sun, 06 Nov 2016 08:24:58 GMT

     [ https://issues.apache.org/jira/browse/SPARK-18292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dongjoon Hyun updated SPARK-18292:
----------------------------------
    Description: 
`LogicalPlanToSQLSuite` uses the following command to update the existing answer files.
{code}
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite"
{code}

However, after introducing `getTestResourcePath`, it fails to update the previous golden answer
files in the predefined directory. This issue aims to fix that.

  was:
`LogicalPlanToSQLSuite` uses the following command to update the existing answer files.
{code}
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite"
{code}

However, after introducing `getTestResourcePath`, it fails to update the previous golden answer
files in the predefined directory. This issue aims to fix that by recovering the original
path.

{code}
-  private val goldenSQLPath = getTestResourcePath("sqlgen")
+  private val goldenSQLPath = "src/test/resources/sqlgen/"
{code}


> LogicalPlanToSQLSuite should not use resource dependent path for golden file generation
> ---------------------------------------------------------------------------------------
>
>                 Key: SPARK-18292
>                 URL: https://issues.apache.org/jira/browse/SPARK-18292
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.0.1
>            Reporter: Dongjoon Hyun
>
> `LogicalPlanToSQLSuite` uses the following command to update the existing answer files.
> {code}
> SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite"
> {code}
> However, after introducing `getTestResourcePath`, it fails to update the previous golden
answer files in the predefined directory. This issue aims to fix that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message