spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Antes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-16808) History Server main page does not honor APPLICATION_WEB_PROXY_BASE
Date Wed, 02 Nov 2016 12:45:58 GMT

    [ https://issues.apache.org/jira/browse/SPARK-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628853#comment-15628853
] 

Jeff Antes commented on SPARK-16808:
------------------------------------

One possible solution is in the /core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala.


  private[history] def getAttemptURI(appId: String, attemptId: Option[String]): String = {
    val attemptSuffix = attemptId.map { id => s"/$id" }.getOrElse("")
    UIUtils.prependBaseUri(s"${HistoryServer.UI_PATH_PREFIX}/${appId}${attemptSuffix}") 
  }

In the 1.6.x line of code the UIUtils.prependBaseUri was positioned where this method was
called.  The rewrite removed it.  Fixing it here appears to be better semantically.

> History Server main page does not honor APPLICATION_WEB_PROXY_BASE
> ------------------------------------------------------------------
>
>                 Key: SPARK-16808
>                 URL: https://issues.apache.org/jira/browse/SPARK-16808
>             Project: Spark
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Michael Gummelt
>
> The root of the history server is rendered dynamically with javascript, and this doesn't
honor APPLICATION_WEB_PROXY_BASE: https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html#L67
> Other links in the history server do honor it: https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/UIUtils.scala#L146
> This means the links on the history server root page are broken when deployed behind
a proxy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message