Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D14C3200BBA for ; Fri, 30 Sep 2016 23:32:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CE7B5160AE7; Fri, 30 Sep 2016 21:32:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1BAF3160AE5 for ; Fri, 30 Sep 2016 23:32:22 +0200 (CEST) Received: (qmail 56513 invoked by uid 500); 30 Sep 2016 21:32:21 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 56249 invoked by uid 99); 30 Sep 2016 21:32:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2016 21:32:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3458F2C2A65 for ; Fri, 30 Sep 2016 21:32:21 +0000 (UTC) Date: Fri, 30 Sep 2016 21:32:21 +0000 (UTC) From: "Sean Owen (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-17746) Code duplication to compute the path to spark-defaults.conf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 30 Sep 2016 21:32:24 -0000 [ https://issues.apache.org/jira/browse/SPARK-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537130#comment-15537130 ] Sean Owen commented on SPARK-17746: ----------------------------------- I'm not sure it can, because core and launcher don't / can't depend on each other? > Code duplication to compute the path to spark-defaults.conf > ----------------------------------------------------------- > > Key: SPARK-17746 > URL: https://issues.apache.org/jira/browse/SPARK-17746 > Project: Spark > Issue Type: Improvement > Components: Spark Core > Affects Versions: 2.1.0 > Reporter: Jacek Laskowski > Priority: Minor > > [CommandBuilderUtils.DEFAULT_PROPERTIES_FILE|https://github.com/apache/spark/blob/master/launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java#L31], [AbstractCommandBuilder.getConfDir|https://github.com/apache/spark/blob/master/launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java#L312] and [Utils.getDefaultPropertiesFile|https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/Utils.scala#L2006] are dealing with the default properties file, i.e. {{spark-defaults.conf}} (or the Spark configuration directory where the file is). > The code duplication could be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org