spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-17746) Code duplication to compute the path to spark-defaults.conf
Date Fri, 30 Sep 2016 21:32:21 GMT

    [ https://issues.apache.org/jira/browse/SPARK-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537130#comment-15537130
] 

Sean Owen commented on SPARK-17746:
-----------------------------------

I'm not sure it can, because core and launcher don't / can't depend on each other?

> Code duplication to compute the path to spark-defaults.conf
> -----------------------------------------------------------
>
>                 Key: SPARK-17746
>                 URL: https://issues.apache.org/jira/browse/SPARK-17746
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 2.1.0
>            Reporter: Jacek Laskowski
>            Priority: Minor
>
> [CommandBuilderUtils.DEFAULT_PROPERTIES_FILE|https://github.com/apache/spark/blob/master/launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java#L31],
[AbstractCommandBuilder.getConfDir|https://github.com/apache/spark/blob/master/launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java#L312]
and [Utils.getDefaultPropertiesFile|https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/Utils.scala#L2006]
are dealing with the default properties file, i.e. {{spark-defaults.conf}} (or the Spark configuration
directory where the file is).
> The code duplication could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message