spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shivaram Venkataraman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-16509) Rename window.partitionBy and window.orderBy
Date Wed, 13 Jul 2016 23:49:20 GMT

    [ https://issues.apache.org/jira/browse/SPARK-16509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376019#comment-15376019
] 

Shivaram Venkataraman commented on SPARK-16509:
-----------------------------------------------

Thats good to know -- [~felixcheung] Can you open a PR if you get a chance ? Its better to
not miss the 2.0 RC for just this one (the other CRAN changes necessary don't need API changes
from what I can see)

> Rename window.partitionBy and window.orderBy
> --------------------------------------------
>
>                 Key: SPARK-16509
>                 URL: https://issues.apache.org/jira/browse/SPARK-16509
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SparkR
>            Reporter: Shivaram Venkataraman
>
> Right now R CMD check [1]  interprets window.partitonBy and window.orderBy as S3 functions
defined on the "partitionBy" class or "orderBy" class (similar to say summary.lm) 
> To avoid confusion I think we should just rename the functions and not use `.` in them
?
> cc [~sunrui]
> [1] https://gist.github.com/shivaram/62866c4ca59c5d34b8963939cf04b5eb



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message