spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-10591) False negative in QueryTest.checkAnswer
Date Sun, 26 Jun 2016 10:13:33 GMT

    [ https://issues.apache.org/jira/browse/SPARK-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350065#comment-15350065
] 

Dongjoon Hyun commented on SPARK-10591:
---------------------------------------

Hi, [~lian cheng].
When I check this today, it is handled by `Row.equals` correctly.
I just make a PR for ensuring this for the future.
If that is not worth a cent, you can close this issue as Not A Problem. :)

> False negative in QueryTest.checkAnswer
> ---------------------------------------
>
>                 Key: SPARK-10591
>                 URL: https://issues.apache.org/jira/browse/SPARK-10591
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL, Tests
>    Affects Versions: 1.0.2, 1.1.1, 1.2.2, 1.3.1, 1.4.1, 1.5.0
>            Reporter: Cheng Lian
>
> {{checkAnswer}} doesn't handle {{Map\[K, V\]}} properly. For example:
> {noformat}
> scala> Map(1 -> 2, 2 -> 1).toString
> res0: String = Map(1 -> 2, 2 -> 1)
> scala> Map(2 -> 1, 1 -> 2).toString
> res1: String = Map(2 -> 1, 1 -> 2)
> {noformat}
> We can't rely on {{toString}} to compare {{Map\[K, V\]}} instances.
> Need to update {{checkAnswer}} to special case {{Map\[K, V\]}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message