spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-13920) MIMA checks should apply to @Experimental and @DeveloperAPI APIs
Date Wed, 16 Mar 2016 02:13:33 GMT

    [ https://issues.apache.org/jira/browse/SPARK-13920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196626#comment-15196626
] 

Dongjoon Hyun commented on SPARK-13920:
---------------------------------------

Oh, [~joshrosen]. 
I totally agree with the purpose of this issue. 
I'll start to work this issue.

> MIMA checks should apply to @Experimental and @DeveloperAPI APIs
> ----------------------------------------------------------------
>
>                 Key: SPARK-13920
>                 URL: https://issues.apache.org/jira/browse/SPARK-13920
>             Project: Spark
>          Issue Type: Bug
>          Components: Project Infra
>            Reporter: Josh Rosen
>
> Our MIMA binary compatibility checks currently ignore APIs which are marked as {{@Experimental}}
or {{@DeveloperApi}}, but I don't think this makes sense. Even if those annotations _reserve_
the right to break binary compatibility, we should still avoid compatibility breaks whenever
possible and should be informed explicitly when compatibility breaks.
> As a result, we should update GenerateMIMAIgnore to stop ignoring classes and methods
which have those annotations. To remove the ignores, remove the checks from https://github.com/apache/spark/blob/643649dcbfabc5d6952c2ecfb98286324c887665/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala#L43
> After removing the ignores, update {{project/MimaExcludes.scala}} to add exclusions for
binary compatibility breaks introduced in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message