spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph K. Bradley (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-11259) Params.validateParams() should be called automatically
Date Mon, 04 Jan 2016 21:31:39 GMT

     [ https://issues.apache.org/jira/browse/SPARK-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joseph K. Bradley resolved SPARK-11259.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request 9224
[https://github.com/apache/spark/pull/9224]

> Params.validateParams() should be called automatically
> ------------------------------------------------------
>
>                 Key: SPARK-11259
>                 URL: https://issues.apache.org/jira/browse/SPARK-11259
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Yanbo Liang
>            Assignee: Yanbo Liang
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Params.validateParams() can not be called automatically currently. Such as the following
code snippet will not throw exception which is not as expected.
> {code}
> val df = sqlContext.createDataFrame(
>       Seq(
>         (1, Vectors.dense(0.0, 1.0, 4.0), 1.0),
>         (2, Vectors.dense(1.0, 0.0, 4.0), 2.0),
>         (3, Vectors.dense(1.0, 0.0, 5.0), 3.0),
>         (4, Vectors.dense(0.0, 0.0, 5.0), 4.0))
>     ).toDF("id", "features", "label")
> val scaler = new MinMaxScaler()
>          .setInputCol("features")
>          .setOutputCol("features_scaled")
>          .setMin(10)
>          .setMax(0)
> val pipeline = new Pipeline().setStages(Array(scaler))
> pipeline.fit(df)
> {code}
> validateParams() should be called by PipelineStage(Pipeline/Estimator/Transformer) automatically,
so I propose to put it in transformSchema(). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message