Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 407151889E for ; Wed, 9 Dec 2015 19:39:11 +0000 (UTC) Received: (qmail 60926 invoked by uid 500); 9 Dec 2015 19:39:11 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 60882 invoked by uid 500); 9 Dec 2015 19:39:11 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 60853 invoked by uid 99); 9 Dec 2015 19:39:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Dec 2015 19:39:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0833D2C14F6 for ; Wed, 9 Dec 2015 19:39:11 +0000 (UTC) Date: Wed, 9 Dec 2015 19:39:11 +0000 (UTC) From: "Steve Loughran (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (SPARK-11317) YARN HBase token code shouldn't swallow invocation target exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved SPARK-11317. ------------------------------------ Resolution: Duplicate Fix Version/s: 2.0.0 > YARN HBase token code shouldn't swallow invocation target exceptions > -------------------------------------------------------------------- > > Key: SPARK-11317 > URL: https://issues.apache.org/jira/browse/SPARK-11317 > Project: Spark > Issue Type: Bug > Components: YARN > Affects Versions: 1.5.1 > Reporter: Steve Loughran > Fix For: 2.0.0 > > > As with SPARK-11265; the HBase token retrieval code of SPARK-6918 > 1. swallows exceptions it should be rethrowing as serious problems (e.g NoSuchMethodException) > 1. Swallows any exception raised by the HBase client, without even logging the details (it logs that an `InvocationTargetException` was caught, but not the contents) > As such it is potentially brittle to changes in the HBase client code, and absolutely not going to provide any assistance if HBase won't actually issue tokens to the caller. > The code in SPARK-11265 can be re-used to provide consistent and better exception processing -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org