Mailing-List: contact issues-help@spark.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 16 Nov 2015 17:10:11 +0000 (UTC)
From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= <jira@apache.org>
To: issues@spark.apache.org
Message-ID: <JIRA.12913366.1447693042000.82058.1447693811078@Atlassian.JIRA>
In-Reply-To: <JIRA.12913366.1447693042000@Atlassian.JIRA>
References: <JIRA.12913366.1447693042000@Atlassian.JIRA>
 <JIRA.12913366.1447693042790@arcas>
Subject: [jira] [Resolved] (SPARK-11760) SQL Catalyst data time test fails
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/SPARK-11760?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofr=C3=A9 resolved SPARK-11760.
------------------------------------------
    Resolution: Invalid

It has already been fixed by:

{code}
commit 06f1fdba6d1425afddfc1d45a20dbe9bede15e7a
Author: Wenchen Fan <wenchen@databricks.com>
Date:   Mon Nov 16 08:58:40 2015 -0800

    [SPARK-11752] [SQL] fix timezone problem for DateTimeUtils.getSeconds
   =20
    code snippet to reproduce it:
    ```
    TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
    val t =3D Timestamp.valueOf("1900-06-11 12:14:50.789")
    val us =3D fromJavaTimestamp(t)
    assert(getSeconds(us) =3D=3D=3D t.getSeconds)
    ```
   =20
    it will be good to add a regression test for it, but the reproducing co=
de need to change the default timezone, and even we change it back, the `la=
zy val defaultTimeZone` in `DataTimeUtils` is fixed.
   =20
    Author: Wenchen Fan <wenchen@databricks.com>
   =20
    Closes #9728 from cloud-fan/seconds.

{code}

> SQL Catalyst data time test fails
> ---------------------------------
>
>                 Key: SPARK-11760
>                 URL: https://issues.apache.org/jira/browse/SPARK-11760
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 1.6.0
>            Reporter: Jean-Baptiste Onofr=C3=A9
>
> In the sql/catalyst module, test("hours / minute / seconds") fails on the=
 third test data:
> {code}
> - hours / miniute / seconds *** FAILED ***
>   29 did not equal 50 (DateTimeUtilsSuite.scala:370)
> {code}
> Actually, the problem is that it doesn't use the timezone for seconds, so=
, we may have to different timestamp comparison.
> I will submit a PR to fix that in DateTimeUtils.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org