Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E41C1809B for ; Wed, 28 Oct 2015 12:34:28 +0000 (UTC) Received: (qmail 1650 invoked by uid 500); 28 Oct 2015 12:34:28 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 1623 invoked by uid 500); 28 Oct 2015 12:34:28 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 1613 invoked by uid 99); 28 Oct 2015 12:34:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Oct 2015 12:34:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BFA102C14F2 for ; Wed, 28 Oct 2015 12:34:27 +0000 (UTC) Date: Wed, 28 Oct 2015 12:34:27 +0000 (UTC) From: "Steve Loughran (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-11375) History Server "no histories" message to be dynamically generated by ApplicationHistoryProviders MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-11375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978329#comment-14978329 ] Steve Loughran commented on SPARK-11375: ---------------------------------------- This could be implemented with a new method on {{ApplicationHistoryProvider}}; something like {code} getDiagnosticsInfo(): (String, Option[String]) = { ... } {code} which would return two strings: one simple text, and one formatted text for insertion into a {{
}} section. That would allow stack traces to be displayed readably.

A default implementation would simply return the current message.

Note that the HTML would have to be sanitized before display, with angle brackets escaped.

> History Server "no histories" message to be dynamically generated by ApplicationHistoryProviders
> ------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-11375
>                 URL: https://issues.apache.org/jira/browse/SPARK-11375
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 1.5.1
>            Reporter: Steve Loughran
>            Priority: Minor
>
> When there are no histories, the {{HistoryPage}} displays an error text which assumes that the provider is the {{FsHistoryProvider}}, and its sole failure mode is "directory not found"
> {code}
> Did you specify the correct logging directory?
> Please verify your setting of spark.history.fs.logDirectory
> {code}
> Different providers have different failure modes, and even the filesystem provider has some, such as an access control exception, or the specified directly path actually being a file.
> If the {{ApplicationHistoryProvider}} was itself asked to provide an error message, then it could
> * be dynamically generated to show the current state of the history provider
> * potentially include any exceptions to list
> * display the actual values of settings such as the log directory property.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org