spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcelo Vanzin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-11097) Add connection established callback to lower level RPC layer so we don't need to check for new connections in NettyRpcHandler.receive
Date Wed, 14 Oct 2015 16:36:05 GMT

    [ https://issues.apache.org/jira/browse/SPARK-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957230#comment-14957230
] 

Marcelo Vanzin commented on SPARK-11097:
----------------------------------------

Hi [~rxin], can you explain what would be the use case for this? Is it just to simplify the
code?

I'm working on SPARK-10997 and I have changed code around that area a lot. I was able to simplify
the code without the need for a connection established callback.

> Add connection established callback to lower level RPC layer so we don't need to check
for new connections in NettyRpcHandler.receive
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-11097
>                 URL: https://issues.apache.org/jira/browse/SPARK-11097
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Spark Core
>            Reporter: Reynold Xin
>
> I think we can remove the check for new connections in NettyRpcHandler.receive if we
just add a channel registered callback to the lower level network module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message