spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Feynman Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-10691) Make LogisticRegressionModel's evaluate method public
Date Fri, 18 Sep 2015 17:06:04 GMT

    [ https://issues.apache.org/jira/browse/SPARK-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875959#comment-14875959
] 

Feynman Liang commented on SPARK-10691:
---------------------------------------

Also, +1 for calling it "evaluate".

> Make LogisticRegressionModel's evaluate method public
> -----------------------------------------------------
>
>                 Key: SPARK-10691
>                 URL: https://issues.apache.org/jira/browse/SPARK-10691
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 1.5.0
>            Reporter: Hao Ren
>
> The following method in {{LogisticRegressionModel}} is marked as {{private}}, which prevents
users from creating a summary on any given data set. Check [here|https://github.com/feynmanliang/spark/blob/d219fa4c216e8f35b71a26921561104d15cd6055/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala#L272].
> {code}
> // TODO: decide on a good name before exposing to public API
> private[classification] def evaluate(dataset: DataFrame)
> : LogisticRegressionSummary = {
>     new BinaryLogisticRegressionSummary(
>         this.transform(dataset), 
>         $(probabilityCol), 
>         $(labelCol))
> }
> {code}
> This method is definitely necessary to test model performance.
> By the way, the name {{evaluate}} is already pretty good for me.
> [~mengxr] Could you check this ? Thx



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message