spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph K. Bradley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-9793) PySpark DenseVector, SparseVector should override __eq__
Date Wed, 12 Aug 2015 16:35:46 GMT

    [ https://issues.apache.org/jira/browse/SPARK-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693780#comment-14693780
] 

Joseph K. Bradley commented on SPARK-9793:
------------------------------------------

I agree, we can.  However, we should be careful to make sure the {{__hash__}} method matches
the semantics: [https://docs.python.org/2/reference/datamodel.html#object.__hash__]

> PySpark DenseVector, SparseVector should override __eq__
> --------------------------------------------------------
>
>                 Key: SPARK-9793
>                 URL: https://issues.apache.org/jira/browse/SPARK-9793
>             Project: Spark
>          Issue Type: Bug
>          Components: ML, PySpark
>    Affects Versions: 1.5.0
>            Reporter: Joseph K. Bradley
>            Priority: Critical
>
> See [SPARK-9750].
> PySpark DenseVector and SparseVector do not override the equality operator properly.
 They should use semantics, not representation, for comparison.  (This is what Scala currently
does.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message