Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8767C188E6 for ; Mon, 13 Jul 2015 07:04:05 +0000 (UTC) Received: (qmail 55107 invoked by uid 500); 13 Jul 2015 07:04:05 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 55074 invoked by uid 500); 13 Jul 2015 07:04:05 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 55064 invoked by uid 99); 13 Jul 2015 07:04:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 07:04:05 +0000 Date: Mon, 13 Jul 2015 07:04:05 +0000 (UTC) From: "Apache Spark (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (SPARK-8935) Implement code generation for all casts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-8935: ----------------------------------- Assignee: Yijie Shen (was: Apache Spark) > Implement code generation for all casts > --------------------------------------- > > Key: SPARK-8935 > URL: https://issues.apache.org/jira/browse/SPARK-8935 > Project: Spark > Issue Type: Sub-task > Components: SQL > Reporter: Reynold Xin > Assignee: Yijie Shen > > Cast expression only supports a subset of type casts. We should just implement all the possible casts so we don't need to fall back to non-codegen mode. > See Cast.scala > {code} > override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = { > // TODO: Add support for more data types. > (child.dataType, dataType) match { > case (BinaryType, StringType) => > defineCodeGen (ctx, ev, c => > s"${ctx.stringType}.fromBytes($c)") > case (DateType, StringType) => > defineCodeGen(ctx, ev, c => > s"""${ctx.stringType}.fromString( > org.apache.spark.sql.catalyst.util.DateTimeUtils.dateToString($c))""") > case (TimestampType, StringType) => > defineCodeGen(ctx, ev, c => > s"""${ctx.stringType}.fromString( > org.apache.spark.sql.catalyst.util.DateTimeUtils.timestampToString($c))""") > case (_, StringType) => > defineCodeGen(ctx, ev, c => s"${ctx.stringType}.fromString(String.valueOf($c))") > // fallback for DecimalType, this must be before other numeric types > case (_, dt: DecimalType) => > super.genCode(ctx, ev) > case (BooleanType, dt: NumericType) => > defineCodeGen(ctx, ev, c => s"(${ctx.javaType(dt)})($c ? 1 : 0)") > case (dt: DecimalType, BooleanType) => > defineCodeGen(ctx, ev, c => s"!$c.isZero()") > case (dt: NumericType, BooleanType) => > defineCodeGen(ctx, ev, c => s"$c != 0") > case (_: DecimalType, dt: NumericType) => > defineCodeGen(ctx, ev, c => s"($c).to${ctx.primitiveTypeName(dt)}()") > case (_: NumericType, dt: NumericType) => > defineCodeGen(ctx, ev, c => s"(${ctx.javaType(dt)})($c)") > case other => > super.genCode(ctx, ev) > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org