spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Williams (JIRA)" <>
Subject [jira] [Commented] (SPARK-9036) SparkListenerExecutorMetricsUpdate messages not included in JsonProtocol
Date Mon, 27 Jul 2015 23:23:04 GMT


Ryan Williams commented on SPARK-9036:

Heh, [guilty as charged|],
[~pwendell]! I put some more thoughts about this on my long email to dev@ just now, but feel
free to chime in here or there. The fact that {{EventLoggingListener}} doesn't bother with
this one kind of event (as an optimization, I guess?) seems like a strange thing to encode
in the {{JsonProtocol}} itself, to me.

> SparkListenerExecutorMetricsUpdate messages not included in JsonProtocol
> ------------------------------------------------------------------------
>                 Key: SPARK-9036
>                 URL:
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 1.4.0, 1.4.1
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Minor
>             Fix For: 1.5.0
> The JsonProtocol added in SPARK-3454 [doesn't include|]
code for ser/de of [{{SparkListenerExecutorMetricsUpdate}}|]
> The comment notes that they are "not used", which presumably refers to the fact that
the [{{EventLoggingListener}} doesn't write these events|].
> However, individual listeners can and should make that determination for themselves;
I have recently written custom listeners that would like to consume metrics-update messages
as JSON, so it would be nice to round out the JsonProtocol implementation by supporting them.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message