spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-8541) sumApprox and meanApprox doctests are incorrect
Date Mon, 22 Jun 2015 22:28:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596767#comment-14596767
] 

Apache Spark commented on SPARK-8541:
-------------------------------------

User 'megatron-me-uk' has created a pull request for this issue:
https://github.com/apache/spark/pull/6942

> sumApprox and meanApprox doctests are incorrect
> -----------------------------------------------
>
>                 Key: SPARK-8541
>                 URL: https://issues.apache.org/jira/browse/SPARK-8541
>             Project: Spark
>          Issue Type: Test
>          Components: PySpark
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Scott Taylor
>            Priority: Minor
>              Labels: tests
>
> The doctests for sumApprox and meanApprox methods test against an upper bound but not
a lower bound. If there was a regression in the underlying code that caused things to go wrong
the doctest may not fail. For example if sumApprox returned 0 the doctest would return -1
which is less than 0.05. Solution is to use the abs() function to test that the approximate
answer is within 5% of the exact answer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message