spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheng Lian (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-8122) ParquetRelation.enableLogForwarding() may fail to configure loggers
Date Fri, 05 Jun 2015 10:45:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574291#comment-14574291
] 

Cheng Lian commented on SPARK-8122:
-----------------------------------

Hm, just noticed that the logger created in the static initialization block of {{org.apache.parquet.Log}}
is also a local variable.  Not quite sure about the lifetime of a local variable appeared
in a static initialization block though, assuming it behaves the same as other local variable,
namely it goes out of scope out of the static block.  Seems that this makes both {{ParquetRelation.enableLogForwarding()}}
and Parquet itself suffer from the GC issue?

> ParquetRelation.enableLogForwarding() may fail to configure loggers
> -------------------------------------------------------------------
>
>                 Key: SPARK-8122
>                 URL: https://issues.apache.org/jira/browse/SPARK-8122
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 1.5.0
>            Reporter: Konstantin Shaposhnikov
>            Priority: Minor
>
> _enableLogForwarding()_ doesn't hold to the created loggers that can be garbage collected
and all configuration changes will be gone. From https://docs.oracle.com/javase/6/docs/api/java/util/logging/Logger.html
javadocs:  _It is important to note that the Logger returned by one of the getLogger factory
methods may be garbage collected at any time if a strong reference to the Logger is not kept._
> All created logger references need to be kept, e.g. in static variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message