spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shivaram Venkataraman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-6813) SparkR style guide
Date Sat, 20 Jun 2015 01:40:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594263#comment-14594263
] 

Shivaram Venkataraman commented on SPARK-6813:
----------------------------------------------

The list looks good to me. Feel free to add the `.lintr` in the PR which adds your script.
We can update it as we refine the rules etc. 

> SparkR style guide
> ------------------
>
>                 Key: SPARK-6813
>                 URL: https://issues.apache.org/jira/browse/SPARK-6813
>             Project: Spark
>          Issue Type: New Feature
>          Components: SparkR
>            Reporter: Shivaram Venkataraman
>
> We should develop a SparkR style guide document based on the some of the guidelines we
use and some of the best practices in R.
> Some examples of R style guide are:
> http://r-pkgs.had.co.nz/r.html#style 
> http://google-styleguide.googlecode.com/svn/trunk/google-r-style.html
> A related issue is to work on a automatic style checking tool. https://github.com/jimhester/lintr
seems promising
> We could have a R style guide based on the one from google [1], and adjust some of them
with the conversation in Spark:
> 1. Line Length: maximum 100 characters
> 2. no limit on function name (API should be similar as in other languages)
> 3. Allow S4 objects/methods



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message