Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63060C17F for ; Tue, 23 Dec 2014 13:29:13 +0000 (UTC) Received: (qmail 68187 invoked by uid 500); 23 Dec 2014 13:29:13 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 68156 invoked by uid 500); 23 Dec 2014 13:29:13 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 68146 invoked by uid 99); 23 Dec 2014 13:29:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 13:29:13 +0000 Date: Tue, 23 Dec 2014 13:29:13 +0000 (UTC) From: "Apache Spark (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-4938) Adding optimization to simplify the filter condition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256964#comment-14256964 ] Apache Spark commented on SPARK-4938: ------------------------------------- User 'scwf' has created a pull request for this issue: https://github.com/apache/spark/pull/3778 > Adding optimization to simplify the filter condition > ---------------------------------------------------- > > Key: SPARK-4938 > URL: https://issues.apache.org/jira/browse/SPARK-4938 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 1.1.0 > Reporter: wangfei > Fix For: 1.3.0 > > > Adding optimization to simplify the filter condition: > 1 condition that can get the boolean result such as: > a < 3 && a > 5 ---- False > a < 1 || a > 0 ---- True > 2 Simplify And, Or condition, such as the sql (one of hive-testbench > ): > select > sum(l_extendedprice* (1 - l_discount)) as revenue > from > lineitem, > part > where > ( > p_partkey = l_partkey > and p_brand = 'Brand#32' > and p_container in ('SM CASE', 'SM BOX', 'SM PACK', 'SM PKG') > and l_quantity >= 7 and l_quantity <= 7 + 10 > and p_size between 1 and 5 > and l_shipmode in ('AIR', 'AIR REG') > and l_shipinstruct = 'DELIVER IN PERSON' > ) > or > ( > p_partkey = l_partkey > and p_brand = 'Brand#35' > and p_container in ('MED BAG', 'MED BOX', 'MED PKG', 'MED PACK') > and l_quantity >= 15 and l_quantity <= 15 + 10 > and p_size between 1 and 10 > and l_shipmode in ('AIR', 'AIR REG') > and l_shipinstruct = 'DELIVER IN PERSON' > ) > or > ( > p_partkey = l_partkey > and p_brand = 'Brand#24' > and p_container in ('LG CASE', 'LG BOX', 'LG PACK', 'LG PKG') > and l_quantity >= 26 and l_quantity <= 26 + 10 > and p_size between 1 and 15 > and l_shipmode in ('AIR', 'AIR REG') > and l_shipinstruct = 'DELIVER IN PERSON' > ); > Before optimized it is a CartesianProduct, in my locally test this sql hang and can not get result, after optimization the CartesianProduct replaced by ShuffledHashJoin, which only need 20+ seconds to run this sql. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org