spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Rosen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-4714) BlockManager should check whether blocks have already been removed Checking block is null or not after having gotten info.lock in remove block method
Date Wed, 10 Dec 2014 00:13:13 GMT

     [ https://issues.apache.org/jira/browse/SPARK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Rosen updated SPARK-4714:
------------------------------
    Summary: BlockManager should check whether blocks have already been removed Checking block
is null or not after having gotten info.lock in remove block method  (was:  BlockManager.dropFromMemory()
should check whether block has been removed after synchronizing on BlockInfo instance.)

> BlockManager should check whether blocks have already been removed Checking block is
null or not after having gotten info.lock in remove block method
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-4714
>                 URL: https://issues.apache.org/jira/browse/SPARK-4714
>             Project: Spark
>          Issue Type: Improvement
>          Components: Block Manager
>    Affects Versions: 1.1.0
>            Reporter: SuYan
>            Assignee: SuYan
>            Priority: Minor
>              Labels: backport-needed
>             Fix For: 1.0.3, 1.3.0, 1.1.2
>
>
> in removeBlock()/ dropOldBlock()/ dropFromMemory()
> all have the same logic:
> 1. info = blockInfo.get(id)
> 2. if (info != null)
> 3. info.synchronized
> there may be a possibility that while one thread got info.lock while the previous thread
already removed from blockinfo in info.lock. 
> but one thing in current code,  That not check info is null or not, while get info.lock
to remove block, will not cause any errors. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message