Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87C551040A for ; Wed, 19 Nov 2014 22:51:35 +0000 (UTC) Received: (qmail 98889 invoked by uid 500); 19 Nov 2014 22:51:35 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 98779 invoked by uid 500); 19 Nov 2014 22:51:35 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 98670 invoked by uid 99); 19 Nov 2014 22:51:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 22:51:35 +0000 Date: Wed, 19 Nov 2014 22:51:35 +0000 (UTC) From: "Apache Spark (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SPARK-4495) Memory leak in JobProgressListener due to `spark.ui.retainedJobs` not being used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218653#comment-14218653 ] Apache Spark commented on SPARK-4495: ------------------------------------- User 'JoshRosen' has created a pull request for this issue: https://github.com/apache/spark/pull/3372 > Memory leak in JobProgressListener due to `spark.ui.retainedJobs` not being used > -------------------------------------------------------------------------------- > > Key: SPARK-4495 > URL: https://issues.apache.org/jira/browse/SPARK-4495 > Project: Spark > Issue Type: Bug > Components: Spark Core > Affects Versions: 1.2.0 > Reporter: Josh Rosen > Assignee: Josh Rosen > Priority: Blocker > > In the JobProgressListener, we never actually remove jobs from the jobIdToData map. In fact, there's a somewhat embarrassing typo: _retailed_ jobs: > {code} > val retailedJobs = conf.getInt("spark.ui.retainedJobs", DEFAULT_RETAINED_JOBS) > {code} > This was introduced by my patch for [SPARK-2321]: I should have added a test that set {{spark.ui.retainedJobs}} to some low threshold and checked that we only reported information for that many jobs; there was already a corresponding "test LRU eviction of stages" test that I should have just copied and modified. > This only affects the unreleased 1.2.0 version. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org