spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Rosen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-3854) Scala style: require spaces before `{`
Date Thu, 09 Oct 2014 18:38:34 GMT

    [ https://issues.apache.org/jira/browse/SPARK-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165507#comment-14165507
] 

Josh Rosen commented on SPARK-3854:
-----------------------------------

Hey [~sarutak],

I don't really know anything about how Scalastyle works, so I'm going to defer to  [~prashant_]
(ScrapCodes on GitHub), who implemented our current Scalastyle extensions: https://github.com/apache/spark/tree/master/project/spark-style/src/main/scala/org/apache/spark/scalastyle

> Scala style: require spaces before `{`
> --------------------------------------
>
>                 Key: SPARK-3854
>                 URL: https://issues.apache.org/jira/browse/SPARK-3854
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Project Infra
>            Reporter: Josh Rosen
>
> We should require spaces before opening curly braces.  This isn't in the style guide,
but it probably should be:
> {code}
> // Correct:
> if (true) {
>   println("Wow!")
> }
> // Incorrect:
> if (true){
>    println("Wow!")
> }
> {code}
> See https://github.com/apache/spark/pull/1658#discussion-diff-18611791 for an example
"in the wild."
> {{git grep "){"}} shows only a few occurrences of this style.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message