spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chunjun Xiao (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SPARK-3474) Rename the env variable SPARK_MASTER_IP to SPARK_MASTER_HOST
Date Wed, 10 Sep 2014 10:09:28 GMT

    [ https://issues.apache.org/jira/browse/SPARK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128303#comment-14128303
] 

Chunjun Xiao edited comment on SPARK-3474 at 9/10/14 10:09 AM:
---------------------------------------------------------------

I agree we should still support old variable names.
The problem is, if the user takes the old variable name (SPARK_MASTER_IP) and start spark
master like "service spark-master start", the SPARK_MASTER_IP will fail to work.
We should fix it, right?


was (Author: chunjun.xiao):
[~srowen]
I agree we should still support old variable names.
The problem is, if the user takes the old variable name (SPARK_MASTER_IP) and start spark
master like "service spark-master start", the SPARK_MASTER_IP will fail to work.
We should fix it, right?

> Rename the env variable SPARK_MASTER_IP to SPARK_MASTER_HOST
> ------------------------------------------------------------
>
>                 Key: SPARK-3474
>                 URL: https://issues.apache.org/jira/browse/SPARK-3474
>             Project: Spark
>          Issue Type: Bug
>          Components: Deploy
>    Affects Versions: 1.0.1
>            Reporter: Chunjun Xiao
>
> There's some inconsistency regarding the env variable used to specify the spark master
host server.
> In spark source code (MasterArguments.scala), the env variable is "SPARK_MASTER_HOST",
while in the shell script (e.g., spark-env.sh, start-master.sh), it's named "SPARK_MASTER_IP".
> This will introduce an issue in some case, e.g., if spark master is started  via "service
spark-master start", which is built based on latest bigtop (refer to bigtop/spark-master.svc).
> In this case, "SPARK_MASTER_IP" will have no effect.
> I suggest we change SPARK_MASTER_IP in the shell script to SPARK_MASTER_HOST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message