spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
Date Sat, 27 Sep 2014 21:18:33 GMT

    [ https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150778#comment-14150778
] 

Sean Owen commented on SPARK-3359:
----------------------------------

Yeah I noticed this. The problem is that {{sbt-unidoc}} uses {{genjavadoc}}, and it looks
like it generates invalid Java like the snippet you quote (top-level classes can't be private).
That's almost all of the extra warnings.

It seems to have been fixed in {{genjavadoc}} 0.8:
https://github.com/typesafehub/genjavadoc/blob/v0.8/plugin/src/main/scala/com/typesafe/genjavadoc/AST.scala#L107

I can see how to update the plugin in the Maven build, but not yet in the SBT build. If someone
who gets SBT can explain how to set {{unidocGenjavadocVersion}} to "0.8" in the {{genjavadocSettings}}
that is inherited in {{project/SparkBuild.scala}}, I bet that would fix it.

https://github.com/sbt/sbt-unidoc/blob/master/src/main/scala/sbtunidoc/Plugin.scala#L22

> `sbt/sbt unidoc` doesn't work with Java 8
> -----------------------------------------
>
>                 Key: SPARK-3359
>                 URL: https://issues.apache.org/jira/browse/SPARK-3359
>             Project: Spark
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.1.0
>            Reporter: Xiangrui Meng
>            Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error] /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error]                  ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message