spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Armbrust (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-1694) Simplify ColumnBuilder/Accessor class hierarchy
Date Wed, 17 Sep 2014 18:30:35 GMT

     [ https://issues.apache.org/jira/browse/SPARK-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Armbrust resolved SPARK-1694.
-------------------------------------
    Resolution: Fixed

> Simplify ColumnBuilder/Accessor class hierarchy
> -----------------------------------------------
>
>                 Key: SPARK-1694
>                 URL: https://issues.apache.org/jira/browse/SPARK-1694
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 1.0.0
>            Reporter: Cheng Lian
>            Assignee: Cheng Lian
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Current {{ColumnBuilder/Accessor}} class hierarchy design was largely refactored from
the in-memory columnar storage component of Shark. Code related to null values and compression
were factored into {{NullableColumnBuilder/Accessor}} and {{CompressibleColumnBuilder/Accessor}}
and then mixed in as stackable traits. The drawback is:
> # Interactions among these classes were unnecessarily complicated and error prone.
> # Flexibility provided by this design now seems useless
> To simplify this, we can merge {{CompressibleColumnBuilder/Accessor}} and {{NullableColumnBuilder/Accessor}}
into {{NativeColumnBuilder/Accessor}}, simply hard code null value processing and compression
logic together.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message