spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-1527) rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
Date Thu, 17 Apr 2014 15:55:14 GMT

    [ https://issues.apache.org/jira/browse/SPARK-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973091#comment-13973091
] 

Sean Owen commented on SPARK-1527:
----------------------------------

If the paths are only used locally, then an absolute path never hurts (except to be a bit
longer). I assume that since these are references to a temp directory that is by definition
only valid locally, that absolute path is the right thing to use.

In other cases, similar logic may apply. I could imagine in some cases the right thing to
do is transmit a relative path. 

> rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
> -------------------------------------------------------------------------------
>
>                 Key: SPARK-1527
>                 URL: https://issues.apache.org/jira/browse/SPARK-1527
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 0.9.0
>            Reporter: Ye Xianjin
>            Priority: Minor
>              Labels: starter
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In core/src/test/scala/org/apache/storage/DiskBlockManagerSuite.scala
>   val rootDir0 = Files.createTempDir()
>   rootDir0.deleteOnExit()
>   val rootDir1 = Files.createTempDir()
>   rootDir1.deleteOnExit()
>   val rootDirs = rootDir0.getName + "," + rootDir1.getName
> rootDir0 and rootDir1 are in system's temporary directory. 
> rootDir0.getName will not get the full path of the directory but the last component of
the directory. When passing to DiskBlockManage constructor, the DiskBlockerManger creates
directories in pwd not the temporary directory.
> rootDir0.toString will fix this issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message