From dev-return-24001-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Feb 9 02:20:31 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 18EC018064F for ; Fri, 9 Feb 2018 02:20:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08DAF160C5D; Fri, 9 Feb 2018 01:20:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 506FD160C4A for ; Fri, 9 Feb 2018 02:20:30 +0100 (CET) Received: (qmail 55158 invoked by uid 500); 9 Feb 2018 01:20:28 -0000 Mailing-List: contact dev-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@spark.apache.org Received: (qmail 55147 invoked by uid 99); 9 Feb 2018 01:20:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 01:20:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4F81CC08DC for ; Fri, 9 Feb 2018 01:20:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rBfxVY2kxaUF for ; Fri, 9 Feb 2018 01:20:26 +0000 (UTC) Received: from mail-ua0-f178.google.com (mail-ua0-f178.google.com [209.85.217.178]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5FADA5F17B for ; Fri, 9 Feb 2018 01:20:26 +0000 (UTC) Received: by mail-ua0-f178.google.com with SMTP id f5so4174905ual.8 for ; Thu, 08 Feb 2018 17:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=NrVm0gJZNlDY+S5Wox65CTTb4Nm+375pEVUcMS6qjoA=; b=H1ieRdtfI3CDw3ioizs9oMNhQWyXnqDVN9glqznyD+Cx807iOZtN8Z2uPGg96Iw7bo MKIaM6cIFb8gwjkjoG3HUkBix/ncNV3gxsdMLliY5+jtGfvj19pjPtjbTzGDyCna5tg0 5yoGmTtlZMHtgTWEzPK9bVZbDseN5xq5BTVentB0kCZf3hzu2xICIraNxJLpaUrJRHvf IOkxfc6nRooYn/JZdnQuZdY6rFqiuMDTW/JATRqmzV6SuqDtLCg5rZRJKeonShEUyj8b DRdkthrpd7ekxYd+aXocDu21Ldvq/PRunehObYBuA5etSqTQ5Nq1RG8TCAY4Tji6OBeR F3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=NrVm0gJZNlDY+S5Wox65CTTb4Nm+375pEVUcMS6qjoA=; b=i7tdBcuDTmSW6NYNQaM/wyLTkl6Y/alKINWbtoRlvg8VZu6zlKwhmwkveDzyIASmiD K9WolrmwMqgNE/eELc2dWMJrzDCfr3MJnwKoyerJUsZZbe9/NqrB6lY9IjlEfqAeDhrD zIaD2kwQEqpkO8ugpu8N485sk1EFnc11qy4XNEUbousV2KwvnCuSpETt4pzv6B++zBTX LPDc6UgDioy34IkI+RP+NwA8fF1DIzuGtiQUtUGO10jxMadbMrA3NcXdEhW7hAYuDXBd QN8maihgWi7QOF1cdx2YE46/KoA6KuR5hs5zTtyVPFMsyPYlCiZIdzezz2YyQ3clz8BP iBtQ== X-Gm-Message-State: APf1xPCWPMSGoHKyBYDacNyllcZMwVqNM29CuAAbTkkqGinwiqL/aNKc MIVQNijVRieciEyV31pT/9V8ZJ1vnWhAXQqgfyUWRpl4 X-Google-Smtp-Source: AH8x2279BLLFEW6EzjrH7+oZa/XNRDp/f0wDlo5yO5EWaZh0CDm4DuuM8ECZKBvUEyovHU6Ws1ntz9PqY/+93p2Qmuo= X-Received: by 10.176.1.231 with SMTP id 94mr1132595ual.52.1518139219558; Thu, 08 Feb 2018 17:20:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.159.59.132 with HTTP; Thu, 8 Feb 2018 17:20:19 -0800 (PST) In-Reply-To: References: From: Marcelo Vanzin Date: Thu, 8 Feb 2018 17:20:19 -0800 Message-ID: Subject: Re: File JIRAs for all flaky test failures To: dev Content-Type: text/plain; charset="UTF-8" Hey all, I just wanted to bring up Kay's old e-mail about this. If you see a flaky test during a PR, don't just ask for a re-test. File a bug so that we know that test is flaky and someone will eventually take a look at it. A lot of them also make great newbie bugs. I've filed a bunch of these in the past months, and every time I look for the test in jira, there was nothing filed yet. And most of those ended up fixed. Visibility into these things helps getting them fixed. On Wed, Feb 15, 2017 at 12:10 PM, Kay Ousterhout wrote: > Hi all, > > I've noticed the Spark tests getting increasingly flaky -- it seems more > common than not now that the tests need to be re-run at least once on PRs > before they pass. This is both annoying and problematic because it makes it > harder to tell when a PR is introducing new flakiness. > > To try to clean this up, I'd propose filing a JIRA *every time* Jenkins > fails on a PR (for a reason unrelated to the PR). Just provide a quick > description of the failure -- e.g., "Flaky test: DagSchedulerSuite" or > "Tests failed because 250m timeout expired", a link to the failed build, and > include the "Tests" component. If there's already a JIRA for the issue, > just comment with a link to the latest failure. I know folks don't always > have time to track down why a test failed, but this it at least helpful to > someone else who, later on, is trying to diagnose when the issue started to > find the problematic code / test. > > If this seems like too high overhead, feel free to suggest alternative ways > to make the tests less flaky! > > -Kay -- Marcelo --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscribe@spark.apache.org