spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacek Laskowski <ja...@japila.pl>
Subject DDLUtils.isDatasourceTable vs HiveExternalCatalog.isDatasourceTable
Date Wed, 17 Jan 2018 10:07:34 GMT
Hi,

Just spot two very similar isDatasourceTable methods:

1. DDLUtils.isDatasourceTable [1]
2. HiveExternalCatalog.isDatasourceTable [2]

Duplication aside, but there's a small difference between them,
i.e. DDLUtils.isDatasourceTable does toLowerCase(Locale.ROOT). Why is the
difference? Does one have a potential bug?

[1]
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala?utf8=%E2%9C%93#L817
[2]
https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala?utf8=%E2%9C%93#L1393


Pozdrawiam,
Jacek Laskowski
----
https://about.me/JacekLaskowski
Mastering Spark SQL https://bit.ly/mastering-spark-sql
Spark Structured Streaming https://bit.ly/spark-structured-streaming
Mastering Kafka Streams https://bit.ly/mastering-kafka-streams
Follow me at https://twitter.com/jaceklaskowski

Mime
View raw message