Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
From: Jacek Laskowski <jacek@japila.pl>
Date: Sun, 10 Dec 2017 22:16:47 +0100
Message-ID: <CAB_G8Zt6uEpjfF91z4PuKRUJN6So85Zq26aQeFPOnzukm+t9Kw@mail.gmail.com>
Subject: GenerateExec, CodegenSupport and supportCodegen flag off?!
To: dev <dev@spark.apache.org>
Content-Type: multipart/alternative; boundary="f4f5e803e06483d3b9056002ef65"
archived-at: Sun, 10 Dec 2017 21:17:00 -0000

--f4f5e803e06483d3b9056002ef65
Content-Type: text/plain; charset="UTF-8"

Hi,

I'm wondering why a physical operator like GenerateExec would
extend CodegenSupport [1], but had the supportCodegen flag turned off?

What's the meaning of such a combination -- be a CodegenSupport with
supportCodegen off?

[1]
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala#L58-L64

[2]
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala#L125

Pozdrawiam,
Jacek Laskowski
----
https://about.me/JacekLaskowski
Spark Structured Streaming https://bit.ly/spark-structured-streaming
Mastering Apache Spark 2 https://bit.ly/mastering-apache-spark
Follow me at https://twitter.com/jaceklaskowski

--f4f5e803e06483d3b9056002ef65
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>I&#39;m wondering why a physical op=
erator like=C2=A0GenerateExec=C2=A0would extend=C2=A0CodegenSupport [1], bu=
t had the=C2=A0supportCodegen flag turned off?</div><div><br></div><div>Wha=
t&#39;s the meaning of such a combination -- be a CodegenSupport with suppo=
rtCodegen off?</div><div><br></div><div>[1]=C2=A0<a href=3D"https://github.=
com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/e=
xecution/GenerateExec.scala#L58-L64">https://github.com/apache/spark/blob/m=
aster/sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.s=
cala#L58-L64</a></div><div><br></div><div>[2]=C2=A0<a href=3D"https://githu=
b.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql=
/execution/GenerateExec.scala#L125">https://github.com/apache/spark/blob/ma=
ster/sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.sc=
ala#L125</a></div><div><br clear=3D"all"><div><div class=3D"gmail_signature=
"><div dir=3D"ltr"><div><div dir=3D"ltr"><div>Pozdrawiam,</div><div>Jacek L=
askowski</div><div>----</div><div><a href=3D"https://about.me/JacekLaskowsk=
i" target=3D"_blank">https://about.me/JacekLaskowski</a></div><div>Spark St=
ructured Streaming=C2=A0<a href=3D"https://bit.ly/spark-structured-streamin=
g" target=3D"_blank">https://bit.ly/spark-structured-streaming</a></div><di=
v>Mastering Apache Spark 2=C2=A0<a href=3D"https://bit.ly/mastering-apache-=
spark" target=3D"_blank">https://bit.ly/mastering-apache-spark</a></div><di=
v>Follow me at <a href=3D"https://twitter.com/jaceklaskowski" target=3D"_bl=
ank">https://twitter.com/jaceklaskowski</a></div></div></div></div></div></=
div>
</div></div>

--f4f5e803e06483d3b9056002ef65--