Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C8D7F200CB2 for ; Sun, 25 Jun 2017 11:38:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C0E30160BE0; Sun, 25 Jun 2017 09:38:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF3E0160BD8 for ; Sun, 25 Jun 2017 11:38:11 +0200 (CEST) Received: (qmail 29266 invoked by uid 500); 25 Jun 2017 09:38:10 -0000 Mailing-List: contact dev-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@spark.apache.org Received: (qmail 29248 invoked by uid 99); 25 Jun 2017 09:38:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Jun 2017 09:38:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C5BF9189118 for ; Sun, 25 Jun 2017 09:38:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.787 X-Spam-Level: X-Spam-Status: No, score=-0.787 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.796, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=databricks-com.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yiXaaQc77TkY for ; Sun, 25 Jun 2017 09:38:07 +0000 (UTC) Received: from mail-ua0-f175.google.com (mail-ua0-f175.google.com [209.85.217.175]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0BFBC5FD91 for ; Sun, 25 Jun 2017 09:38:07 +0000 (UTC) Received: by mail-ua0-f175.google.com with SMTP id j53so55467110uaa.2 for ; Sun, 25 Jun 2017 02:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=databricks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sr+RH3/xogQH2GGNrQwTwML142BOHx3CdAZOXlo8neA=; b=Tqrxh2XxqjqqlRNLefoxflxy48LCYXXOU4xgJwZRjbp6YQ055EqNyw1jqahG81CWU7 +jUiJn/3dByL25/7cmh64pwB6uzjXseqiAjIiZ8DjEZ+Fi/XTJJJlQN86MIiIbyIzPwF 4rgXVUYrlys4ZU2Buc2IDlYyW83+xH8zfA/reHihpTaSHpQYPkQf+fWe/Ou7/EHN1KfP 0AmTIALA/57QQeSBegBuWPOerd+ZKB+z7U26o5HJqzivcPf6o7zqkWsSyKVuRUT3WshO rxH7NVnGIydtOKDVcuB60jdPHJjqfbGET6uFwpnv2z6U10WVfDJbveQlv9qZpndYfEbi 7XMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sr+RH3/xogQH2GGNrQwTwML142BOHx3CdAZOXlo8neA=; b=E8BP9lQk0D2O7d3GOHMlaIQRt8JS1FWdCAtDwLlNIef0Mrg4B6K4uCsUD/836E219j JwW3QpgGfhIZknnr7XZFJ0VAMmuGdOF2MaxbqJ2P40Ke7GYj0Kxs27lWvWkF1Jwoyw40 pvSiAPLetn+FZ0Pq2SVaoZRzBG44kEOTzT1Oehz1/B6yT+Yvj0LJmrv/VUVTZ2LwFl/X Y6HeThNC+l2S1dXIr4Ax0u9wGd5ZNBnZHmMkX1zLoIyiqUt7KAuSIShlQOMzfmS5TSVD 5rD9OrrklHJCMWJ/EAROagE8TGLxSuKUnjTJMxPd+tvhd6jjDduubei/aUEkXyX0Nxwx /3jA== X-Gm-Message-State: AKS2vOwvCFQE5BNIOHpr27o2ghXKPGzSVTP0mWk3xgmcIziBOsGPOgHa zyz4TlN//YEj/fQGANEISJZO8wXr/dFm X-Received: by 10.176.95.69 with SMTP id z5mr10615756uah.113.1498383480300; Sun, 25 Jun 2017 02:38:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.6.70 with HTTP; Sun, 25 Jun 2017 02:37:59 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?Q?Herman_van_H=C3=B6vell_tot_Westerflier?= Date: Sun, 25 Jun 2017 11:37:59 +0200 Message-ID: Subject: Re: Question on Spark code To: kant kodali Cc: "user @spark" , dev Content-Type: multipart/alternative; boundary="f403045fdfa414ba8e0552c597d4" archived-at: Sun, 25 Jun 2017 09:38:13 -0000 --f403045fdfa414ba8e0552c597d4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I am not getting the question. The logging trait does exactly what is says on the box, I don't see what string concatenation has to do with it. On Sun, Jun 25, 2017 at 11:27 AM, kant kodali wrote: > Hi All, > > I came across this file https://github.com/apache/spark/blob/master/core/ > src/main/scala/org/apache/spark/internal/Logging.scala and I am wondering > what is the purpose of this? Especially it doesn't prevent any string > concatenation and also the if checks are already done by the library itse= lf > right? > > Thanks! > > --=20 Herman van H=C3=B6vell Software Engineer Databricks Inc. hvanhovell@databricks.com +31 6 420 590 27 databricks.com [image: http://databricks.com] [image: Announcing Databricks Serverless. The first serverless data science and big data platform. Watch the demo from Spark Summit 2017.] --f403045fdfa414ba8e0552c597d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I am not getting the question. The logging trait does exac= tly what is says on the box, I don't see what string concatenation has = to do with it.

On Sun, Jun 25, 2017 at 11:27 AM, kant kodali <kanth909@gmail.com&= gt; wrote:
Hi All= ,

I came across this file=C2=A0https://github.com/apache/spark/blob= /master/core/src/main/scala/org/apache/spark/internal/Logging.sca= la and I am wondering what is the purpose of this? Especially it doesn&= #39;t prevent any string concatenation and also the if checks are already d= one by the library itself right?

Thanks!




--

= Herman van H=C3=B6vell

Software Engineer

Databricks = Inc.

hvanhovell@databricks.com

+31 6 420 590 27

databricks.com

3D"http://databricks.com"



3D"Anno=

--f403045fdfa414ba8e0552c597d4--