Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAAOnQ7sFjszmR-dOdjJUYA40qSS_gPGcqOsy8DSRi_pFtAJtYQ@mail.gmail.com>
References: <CAAOnQ7sFjszmR-dOdjJUYA40qSS_gPGcqOsy8DSRi_pFtAJtYQ@mail.gmail.com>
From: "Shixiong(Ryan) Zhu" <shixiong@databricks.com>
Date: Tue, 15 Nov 2016 13:40:26 -0800
Message-ID: <CAGeYWGKfD+Q_vUaLfhBzGi9P8+JP78r=1OueY0hjCbr1SL6_4g@mail.gmail.com>
Subject: Re: Running lint-java during PR builds?
To: Marcelo Vanzin <vanzin@cloudera.com>
Cc: "dev@spark.apache.org" <dev@spark.apache.org>
Content-Type: multipart/alternative; boundary=001a114a727efa28a805415dcdfc
archived-at: Tue, 15 Nov 2016 21:40:35 -0000

--001a114a727efa28a805415dcdfc
Content-Type: text/plain; charset=UTF-8

I remember it's because you need to run `mvn install` before running
lint-java if the maven cache is empty, and `mvn install` is pretty heavy.

On Tue, Nov 15, 2016 at 1:21 PM, Marcelo Vanzin <vanzin@cloudera.com> wrote:

> Hey all,
>
> Is there a reason why lint-java is not run during PR builds? I see it
> seems to be maven-only, is it really expensive to run after an sbt
> build?
>
> I see a lot of PRs coming in to fix Java style issues, and those all
> seem a little unnecessary. Either we're enforcing style checks or
> we're not, and right now it seems we aren't.
>
> --
> Marcelo
>
> ---------------------------------------------------------------------
> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>
>

--001a114a727efa28a805415dcdfc
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I remember it&#39;s because you need to run `mvn install` =
before running lint-java if the maven cache is empty, and `mvn install` is =
pretty heavy.</div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote=
">On Tue, Nov 15, 2016 at 1:21 PM, Marcelo Vanzin <span dir=3D"ltr">&lt;<a =
href=3D"mailto:vanzin@cloudera.com" target=3D"_blank">vanzin@cloudera.com</=
a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0=
 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey all,<br>
<br>
Is there a reason why lint-java is not run during PR builds? I see it<br>
seems to be maven-only, is it really expensive to run after an sbt<br>
build?<br>
<br>
I see a lot of PRs coming in to fix Java style issues, and those all<br>
seem a little unnecessary. Either we&#39;re enforcing style checks or<br>
we&#39;re not, and right now it seems we aren&#39;t.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Marcelo<br>
<br>
------------------------------<wbr>------------------------------<wbr>-----=
----<br>
To unsubscribe e-mail: <a href=3D"mailto:dev-unsubscribe@spark.apache.org">=
dev-unsubscribe@spark.apache.<wbr>org</a><br>
<br>
</font></span></blockquote></div><br></div>

--001a114a727efa28a805415dcdfc--