spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shivaram Venkataraman <shiva...@eecs.berkeley.edu>
Subject Re: Change the settings in AppVeyor to prevent triggering the tests in other PRs in other branches
Date Fri, 09 Sep 2016 17:56:09 GMT
The infra ticket has been updated so I'd say let's stick to running tests
on master branch. We can of course create JIRAs for tests that fail in
branch 2.0 and 1.6

Shivaram

On Sep 9, 2016 09:33, "Hyukjin Kwon" <gurwls223@gmail.com> wrote:

> FYI, I just ran the SparkR tests on Windows for branch-2.0 and 1.6.
>
> branch-2.0 - https://github.com/spark-test/spark/pull/7
> branch-1.6 - https://github.com/spark-test/spark/pull/8
>
>
>
>
> 2016-09-10 0:59 GMT+09:00 Hyukjin Kwon <gurwls223@gmail.com>:
>
>> Yes, if we don't have any PRs to other branches on branch-1.5 and lower
>> versions, I think it'd be fine.
>>
>> One concern is, I am not sure if SparkR tests can pass on  branch-1.6 (I
>> checked it passes on branch-2.0 before).
>>
>> I can try to check if it passes and identify the related causes if it
>> does not pass.
>>
>> On 10 Sep 2016 12:52 a.m., "Shivaram Venkataraman" <
>> shivaram@eecs.berkeley.edu> wrote:
>>
>>> One thing we could do is to backport the commit to branch-2.0 and
>>> branch-1.6 -- Do you think that will fix the problem ?
>>>
>>> On Fri, Sep 9, 2016 at 8:50 AM, Hyukjin Kwon <gurwls223@gmail.com>
>>> wrote:
>>> > Ah, thanks! I wasn't too sure on this so I thought asking here somehow
>>> > reaches out to who's in charge of the account :).
>>> >
>>> >
>>> > On 10 Sep 2016 12:41 a.m., "Shivaram Venkataraman"
>>> > <shivaram@eecs.berkeley.edu> wrote:
>>> >>
>>> >> Thanks for debugging - I'll reply on
>>> >> https://issues.apache.org/jira/browse/INFRA-12590 and ask for this
>>> >> change.
>>> >>
>>> >> FYI I don't any of the committers have access to the appveyor account
>>> >> which is at https://ci.appveyor.com/projec
>>> t/ApacheSoftwareFoundation/spark
>>> >>  . To request changes that need to be done in the UI we need to open
a
>>> >> INFRA ticket.
>>> >>
>>> >> Thanks
>>> >> Shivaram
>>> >>
>>> >> On Fri, Sep 9, 2016 at 6:55 AM, Hyukjin Kwon <gurwls223@gmail.com>
>>> wrote:
>>> >> > Hi all,
>>> >> >
>>> >> >
>>> >> > Currently, it seems the settings in AppVeyor is default and runs
>>> some
>>> >> > tests
>>> >> > on different branches. For example,
>>> >> >
>>> >> >
>>> >> > https://github.com/apache/spark/pull/15023
>>> >> >
>>> >> > https://github.com/apache/spark/pull/15022
>>> >> >
>>> >> >
>>> >> > It seems it happens only in other branches as they don’t have
>>> >> > appveyor.yml
>>> >> > and try to refer the configuration in the web (although I have
to
>>> test
>>> >> > this).
>>> >> >
>>> >> >
>>> >> > I’d be great if any of auhorized one sets the branch to test
to
>>> master
>>> >> > brunch only as described in
>>> >> >
>>> >> >
>>> >> > https://github.com/apache/spark/blob/master/dev/appveyor-gui
>>> de.md#specifying-the-branch-for-building-and-setting-the-build-schedule
>>> >> >
>>> >> >
>>> >> > I just manually tested this. With the setting, it would not trigger
>>> the
>>> >> > test
>>> >> > for another branch, for example,
>>> >> > https://github.com/spark-test/spark/pull/5
>>> >> >
>>> >> > Currently, with the default settings, it will run the tests on
>>> another
>>> >> > branch, for example, https://github.com/spark-test/spark/pull/4
>>> >> >
>>> >> >
>>> >> > Thanks.
>>> >> >
>>> >> >
>>> >> >
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>> >>
>>> >
>>>
>>
>

Mime
View raw message