Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: 
 <CALte62wHgM-wxDtDR0WLEd_qmArJrz0_k4SQP41BPcdobT_3gw@mail.gmail.com>
References: 
 <CAMAsSdJGOzWfsXRfjkJUgsCVo8GqWXNkgi_ygOTwFhUzsgfJog@mail.gmail.com>
 <D040909C-4490-450A-AEDC-314943F061A2@gmail.com>
 <CAMAsSd+20aNY-_oSZwKgHZEJbeH7oLWLx0tAtN_Nu43PurTdYQ@mail.gmail.com>
 <CALte62wHgM-wxDtDR0WLEd_qmArJrz0_k4SQP41BPcdobT_3gw@mail.gmail.com>
From: Sean Owen <sowen@cloudera.com>
Date: Fri, 4 Mar 2016 15:06:46 +0000
Message-ID: 
 <CAMAsSdKLXw6ohBBD3dHi9tr=KsGV8Kjdr3O+mqDktD42NEJbpQ@mail.gmail.com>
Subject: Re: Set up a Coverity scan for Spark
To: Ted Yu <yuzhihong@gmail.com>
Cc: dev <dev@spark.apache.org>
Content-Type: text/plain; charset=UTF-8

Hi Ted, I've already marked them. You should be able to see the ones
marked "Fix Required" if you click through to the defects. Most are
just bad form and probably have no impact. The few that looked
reasonably important were:

- using platform char encoding, not UTF-8
- Incorrect notify/wait
- volatile count with non-atomic update
- bad equals/hashCode

On Fri, Mar 4, 2016 at 2:52 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> Last time I checked there wasn't high impact defects.
>
> Mind pointing out the defects you think should be fixed ?
>
> Thanks
>
> On Fri, Mar 4, 2016 at 4:35 AM, Sean Owen <sowen@cloudera.com> wrote:
>>
>> Yeah, it's not going to help with Scala, but it can at least find
>> stuff in the Java code. I'm not suggesting anyone run it regularly,
>> but one run to catch some bugs is useful.
>>
>> I've already triaged ~70 issues there just in the Java code, of which
>> a handful are important.
>>
>> On Fri, Mar 4, 2016 at 12:18 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>> > Since majority of code is written in Scala which is not analyzed by
>> > Coverity, the efficacy of the tool seems limited.
>> >
>> >> On Mar 4, 2016, at 2:34 AM, Sean Owen <sowen@cloudera.com> wrote:
>> >>
>> >>
>> >> https://scan.coverity.com/projects/apache-spark-2f9d080d-401d-47bc-9dd1-7956c411fbb4?tab=overview
>> >>
>> >> This has to be run manually, and is Java-only, but the inspection
>> >> results are pretty good. Anyone should be able to browse them, and let
>> >> me know if anyone would like more access.
>> >> Most are false-positives, but it's found some reasonable little bugs.
>> >>
>> >> When my stack of things to do clears I'll try to address them, but I
>> >> bring it up as an FYI for anyone interested in static analysis.
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
>> >> For additional commands, e-mail: dev-help@spark.apache.org
>> >>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org