spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Automatically deleting pull request comments left by AmplabJenkins
Date Fri, 14 Aug 2015 02:54:19 GMT
Thanks Josh for the initiative.

I think reducing the redundancy in QA bot posts would make discussion on GitHub
UI more focused.

Cheers

On Thu, Aug 13, 2015 at 7:21 PM, Josh Rosen <rosenville@gmail.com> wrote:

> Prototype is at https://github.com/databricks/spark-pr-dashboard/pull/59
>
> On Wed, Aug 12, 2015 at 7:51 PM, Josh Rosen <rosenville@gmail.com> wrote:
>
>> *TL;DR*: would anyone object if I wrote a script to auto-delete pull
>> request comments from AmplabJenkins?
>>
>> Currently there are two bots which post Jenkins test result comments to
>> GitHub, AmplabJenkins and SparkQA.
>>
>> SparkQA is the account which post the detailed Jenkins start and finish
>> messages that contain information on which commit is being tested and which
>> tests have failed. This bot is controlled via the dev/run-tests-jenkins
>> script.
>>
>> AmplabJenkins is controlled by the Jenkins GitHub Pull Request Builder
>> plugin. This bot posts relatively uninformative comments ("Merge build
>> triggered", "Merge build started", "Merge build failed") that do not
>> contain any links or details specific to the tests being run.
>>
>> It is technically non-trivial prevent these AmplabJenkins comments from
>> being posted in the first place (see
>> https://issues.apache.org/jira/browse/SPARK-4216).
>>
>> However, as a short-term hack I'd like to deploy a script which
>> automatically deletes these comments as soon as they're posted, with an
>> exemption carved out for the "Can an admin approve this patch for testing?"
>> messages. This will help to significantly de-clutter pull request
>> discussions in the GitHub UI.
>>
>> If nobody objects, I'd like to deploy this script sometime in the next
>> few days.
>>
>> (From a technical perspective, my script uses the GitHub REST API and
>> AmplabJenkins' own OAuth token to delete the comments.  The final
>> deployment environment will most likely be the backend of
>> http://spark-prs.appspot.com).
>>
>> - Josh
>>
>
>

Mime
View raw message